redumper icon indicating copy to clipboard operation
redumper copied to clipboard

Duplicate DI information printed

Open Deterous opened this issue 1 year ago • 0 comments

During the dump step of a BD disc, the DI information gets duplicated. I believe this is because the DI information already prints for each layer, but print_di_units_structure now gets called once per layer: https://github.com/superg/redumper/blob/be37c5881eb09c15b7874b8aeb5a2dc6f34cc218/dvd/dvd_dump.ixx#L452-L453 So, I believe it is due to recent changes in #5f6a2da

Additionally, two *.physical files are produced now, a .0.physical and a .1.physical. They are bit-for-bit identical. Is this intended? Perhaps if they are identical, redumper can only output one?

Of course, this could be intentional if I am misunderstanding something. In which case, perhaps only printing it twice if the DI differs for each structure?

Example output from a two-layer PS5 disc, where DI information is printed twice:

*** DUMP

disc structure:
  DI { format: 1, layer: 0, sequence number: 0, unit size: 32, continuation: 0 }
    disc type: BDU
    disc size: 120mm
    disc class: 3
    disc version: 2
    layers count: 2
    channel length: reserved3
    polarity: 3
    BCA: no
    PSN last { PSN: 53009887, hPSN: 0x328DDDF }
    AUN { PSN: [1048576 .. 17341438], length: 16292864, hPSN: [0x100000 .. 0x1089BFE] }
  DI { format: 1, layer: 1, sequence number: 1, unit size: 32, continuation: 0 }
    disc type: BDU
    disc size: 120mm
    disc class: 3
    disc version: 2
    layers count: 2
    channel length: reserved3
    polarity: 3
    BCA: no
    PSN last { PSN: 53009887, hPSN: 0x328DDDF }
    AUN { PSN: [49767424 .. 66060286], length: 16292864, hPSN: [0x2F76400 .. 0x3EFFFFE] }
  DI { format: 1, layer: 0, sequence number: 0, unit size: 32, continuation: 0 }
    disc type: BDU
    disc size: 120mm
    disc class: 3
    disc version: 2
    layers count: 2
    channel length: reserved3
    polarity: 3
    BCA: no
    PSN last { PSN: 53009887, hPSN: 0x328DDDF }
    AUN { PSN: [1048576 .. 17341438], length: 16292864, hPSN: [0x100000 .. 0x1089BFE] }
  DI { format: 1, layer: 1, sequence number: 1, unit size: 32, continuation: 0 }
    disc type: BDU
    disc size: 120mm
    disc class: 3
    disc version: 2
    layers count: 2
    channel length: reserved3
    polarity: 3
    BCA: no
    PSN last { PSN: 53009887, hPSN: 0x328DDDF }
    AUN { PSN: [49767424 .. 66060286], length: 16292864, hPSN: [0x2F76400 .. 0x3EFFFFE] }

layer break: 2

Deterous avatar May 24 '24 02:05 Deterous