flyctl icon indicating copy to clipboard operation
flyctl copied to clipboard

`fly launch` doesn't work on nuxt 3 aplication.

Open Rohithgilla12 opened this issue 2 years ago • 6 comments

Please only report specific issues with flyctl behavior. Anything like a support request for your application should go to https://community.fly.io. More people watch that space and can help you faster!

Describe the bug

Was following this guide, the fly launch command detected the nuxt app as a node app.

  • Operating system macOS
  • fly version : 0.1.7 image

** Paste your fly.toml Generates a node js docker file.

** Command output: **

image

❯ fly launch
Creating app in /tmp/nuxt-app
Scanning source code
Detected a NodeJS app ?

Rohithgilla12 avatar Aug 07 '23 03:08 Rohithgilla12

https://github.com/superfly/flyctl/blob/64a31bf73c6e1509567cc6be0b2a19340e80e810/scanner/nuxtjs.go#L4 I think the issue is here. Configuration · Get Started with Nuxt uses nuxt.config.ts by default.

redjonzaci avatar Sep 10 '23 11:09 redjonzaci

I just made it work @Rohithgilla12! Opening a PR.

redjonzaci avatar Sep 10 '23 12:09 redjonzaci

That's so cool Thanks a lot 🫡

Rohithgilla12 avatar Sep 10 '23 13:09 Rohithgilla12

Hope this gets merged tomorrow. Otherwise, will tag a Fly.io team member.

redjonzaci avatar Sep 10 '23 13:09 redjonzaci

@redjonzaci Looks like it's not reviewed yet 👀

Rohithgilla12 avatar Sep 14 '23 03:09 Rohithgilla12

Hey @Rohithgilla12, sorry about that, but I am sure Fly.io team members must be working on higher priority issues.

To unblock you, you can rename nuxt.config.ts to nuxt.config.js and then when fly launch prompts you to deploy, deny and add these changes to the Dockerfile that is generated: https://github.com/superfly/flyctl/pull/2812/commits/42f1aa8e49f4f257a4e5d2c12f78198a7f6449a5#diff-27c9f5cf2c02c33c96d414a8acc31092e11ebd1df8ba68884a55830b17523b9a

And then fly deploy.

Let me know if it works!

redjonzaci avatar Sep 14 '23 06:09 redjonzaci