flyctl-actions icon indicating copy to clipboard operation
flyctl-actions copied to clipboard
verified publisher icon superfly

Revamp

Open smorimoto opened this issue 1 year ago • 7 comments

This PR adds support for all platforms and architectures supported by flyctl.

smorimoto avatar Jul 26 '24 06:07 smorimoto

Thanks for the PR! There are quite a lot of unrelated changes in here. Can you pull those into separate PRs, keeping this one focused on the architecture support?

jsierles avatar Jul 26 '24 06:07 jsierles

@jsierles Ooh, I just wrote some comments to make the review easier. Do you still want to split? (That's fine 🙃)

smorimoto avatar Jul 26 '24 06:07 smorimoto

While I think some of these changes are good, it would be best to keep them in separate PRs.

jsierles avatar Jul 26 '24 06:07 jsierles

OK!

smorimoto avatar Jul 26 '24 06:07 smorimoto

@jsierles Done! #64

smorimoto avatar Jul 26 '24 06:07 smorimoto

I just rebased this on top of #64, so I will rebase again after merging #64.

smorimoto avatar Jul 26 '24 15:07 smorimoto

CI results: https://github.com/smorimoto/flyctl-actions/actions/runs/10113801238

smorimoto avatar Jul 26 '24 15:07 smorimoto

@jsierles Ready for review!

smorimoto avatar Aug 01 '24 01:08 smorimoto

Can you update the PR description to summarize the changes here?

jsierles avatar Aug 01 '24 06:08 jsierles

@jsierles Done!

smorimoto avatar Aug 02 '24 17:08 smorimoto