corrosion icon indicating copy to clipboard operation
corrosion copied to clipboard

keep gossip address the same as the actor address

Open runsisi opened this issue 1 year ago • 3 comments

runsisi avatar Aug 29 '24 14:08 runsisi

Is that causing issues?

jeromegn avatar Sep 02 '24 21:09 jeromegn

we store actor address (self.external_addr().unwrap_or_else(|| self.gossip_addr()))^1 in __corro_members table^2, while in spawn_swim_announcer to skip local node announce^3 gossip address (gossip_server_endpoint.local_addr())^4 is used as local address, i.e., our_addr. i think this is not correct.

maybe we should change generate_bootstrap ^5 signiture to ignore skip both gossip address and external address?

runsisi avatar Sep 04 '24 06:09 runsisi

maybe we should change generate_bootstrap 5 signiture to ignore skip both gossip address and external address?

@runsisi I think this is a better solution.

somtochiama avatar Sep 20 '24 14:09 somtochiama