protocol-monorepo icon indicating copy to clipboard operation
protocol-monorepo copied to clipboard

Published 20 hours ago • verified publisher icon superfluid-finance

[ETHEREUM-CONTRACTS] Review callback gas limit issue

Open hellwolf opened this issue 4 years ago • 2 comments

Synopsis

Currently callbacks have a CALLBACK_GAS_LIMIT of 3M gas, and _callCallback should detect the genuine out of gas callback issue vs. out of gas grievance attacks.

Co-reviewer: Hadrien

  • Adding a section to https://github.com/superfluid-finance/protocol-monorepo/wiki/About-Call-Proxies

References

  • the 63/64 gas limit trick: https://ronan.eth.link/blog/ethereum-gas-dangers/

hellwolf avatar Dec 16 '20 23:12 hellwolf

@hellwolf is it possible to add more details here do you think and put into tech debt? or better to close

vmichalik avatar Sep 04 '23 14:09 vmichalik

Moving to technical debt, waiting for adding a section to https://github.com/superfluid-finance/protocol-monorepo/wiki/About-Call-Proxies

hellwolf avatar Sep 05 '23 07:09 hellwolf

Concluded with CallbackUtils https://github.com/superfluid-finance/protocol-monorepo/pull/1979

hellwolf avatar Jul 08 '24 19:07 hellwolf