Beatbox
Beatbox copied to clipboard
superfell
Add unit tests
really need some unit tests, especially now that we're supporting both python 2 & 3.
Once we have tests, should also setup travis to run them
It's fine that you are writing tests. Do you want to continue with the project? Where to write an updated documentation? I understand that you want to promote your site www.pocketsoap.com, but there is an old info e.g. that "20.0 API is currently supported".
beatbox existed before Github did, so that's why the docs are still there. We can copy them into the repo, either in readme.md or a new file, and expand then with the new features, that's fine.
Please combine the docs page with README.md. I prefer that I write new tests mostly only to an unused project wiki and the project owner rewrites sometimes important parts to the readme. My English skills are so weak that most my texts must be fixed and simplified. I usually must rewrite it first more times before I can understand my English clear also with a time delay. It is very different from my code that usually doesn't need a fix.
I know that you were active in many forums about Salesforce, thanks to good knowledge of API. That time before github, It was complicated for all to communicate between their forks and to send pull requests and discuss about them. I would probably also not communicate with the people around code.google fork all with so much wild animal names and no normal name. I think that two forks are currently important: davisagli/beatbox - the last release 32.0 on PyPI (he is very active on github, but he was active with beatbox only for one week while he has been fixing the code) and a renamed fork alanjcastonguay/pyforce with some active users around. Do you think that a Python client is a good idea?
I don't hurry in this direction because my first intention is to use soap api in django-salesforce and I want the robust ground more than an upper layer. I'm preparing some PR to make the package more robust and universal. Then it could be a more interesting position for some simple negotiation.
The pyforce fork mostly adds marshaling. It has been useful, but could be altered to take beatbox as a dependency for core logic. But I haven't been using salesforce at all for the last year.
@alanjcastonguay Thanks for your information. (Did you quit Salesforce for some technical reason or more for a administrative reason in your company?)
I started to play with python_client to convert it Python 3. The result is ready in github hynekcer/beatbox-davisagli. All their tests passed. I tried your pyforce first, but I had problems with tests even in Python 2. There are some undefined variables and attributes in pyforce tests. Some last edits has been probably written without running them really. So the davisagli beatbox 32 was easier for update.
I wrote also a refactoring branch to make the package more modular and to be possible to replace .e.g. the network layer and to implement a special proxy #5 or something similar by a smart parameter in Client() constructor, without changing anything in Beatbox. Only for information. I still can not find a reason strong enough for PR, what can not be realized simpler.
@hynekcer (Sorry for the confusion: I moved within the same company but to working on other projects that don't have a close relationship to the data we store in Salesforce. My old team is still happily using it, leveraging either pyforce or beatbox depending on needs. So while I don't have as much personal investment these days, I'd still like other people to be successful.)