one-sdk-js icon indicating copy to clipboard operation
one-sdk-js copied to clipboard

Add Node 19 to CI Tests

Open freaz opened this issue 3 years ago • 0 comments

Description

Runs OneSDK on Node 19.

Found bug in mockttp, where connection header is deleted and client doesn't know how to behave.

I choose to use Connection: close because with keep-alive, I would need to set also Keep-Alive: timeout=5. And I hope I will be able to fix mockttp eventually, so this can be reverted.

Motivation and Context

I want to have OneSDK tested on all supported Node.js versions

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] I have updated the documentation accordingly. If you are changing code related to user secrets you need to really make sure that security documentation is correct.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I haven't repeated the code. (DRY)
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

freaz avatar Jan 12 '23 14:01 freaz