superduper icon indicating copy to clipboard operation
superduper copied to clipboard

remove the other ibis from the pyproject.toml

Open lostmygithubaccount opened this issue 10 months ago • 1 comments

hello, I believe the use of ibis -- a Jinja templating framework thing -- and not ibis-framework, the portable Python dataframe library

this just removes that line, not sure if it's sufficient

Description

Related Issues

Checklist

  • [ ] Is this code covered by new or existing unit tests or integration tests?
  • [ ] Did you run make unit-testing and make integration-testing successfully?
  • [ ] Do new classes, functions, methods and parameters all have docstrings?
  • [ ] Were existing docstrings updated, if necessary?
  • [ ] Was external documentation updated, if necessary?

Additional Notes or Comments

lostmygithubaccount avatar Apr 19 '24 17:04 lostmygithubaccount

@lostmygithubaccount Hey, thanks, could you help to update te CHANGELOG file? The CI checks the CHANGELOG for every PR

jieguangzhou avatar Apr 22 '24 02:04 jieguangzhou

Thank-you @lostmygithubaccount! We solved this in another PR - thanks for pointing out!

blythed avatar May 13 '24 08:05 blythed