superdesk-client-core
superdesk-client-core copied to clipboard
superdesk
Content profiles for non text content types
What's needed on this PR? A lot of tests are failing so I'm guessing there's still some work to do here
hey @tomaskikutis everything is fixed now as requested. Can you please check it and merge if it is fine?
This is fixed, but now textarea is visually identical to single line text input. It'd be good to make it higher so it's possible to differentiate them Textareas got auto height, so if you type in two lines, it will get heigher.
When there is already one image content profile, and new content profile is being created, image type should be disabled and not available for selection. It is not disabled (at least it's not apparent visually). I wasn't able to reproduce this, can you do some screen recording to show where this is problem?
Textareas got auto height, so if you type in two lines, it will get heigher.
The problem is that it's not possible to visually see which component it is, without trying it out. If default height was 2 lines, it would be obvious then. It's not an important issue, we can leave it if it's not easy to fix.
I wasn't able to reproduce this, can you do some screen recording to show where this is problem?
Upon checking again I can't either. Maybe it was my messy database.
I wasn't able to reproduce this, can you do some screen recording to show where this is problem?
I found a similar issue though, that image option is disabled, but is shown as enabled in the UI until some other option is clicked.
@tomaskikutis can we merge this PR now? UI issues reported in this PR are all mainly on ui-framework side (double modal and dropdown issue). We changed dropdowns and modals in version 3, so once we switched to this version everything will be fixed. For now, from my point of view this are minnor issues, and this ticket is opened to long. I will create following ticket with issues listed in it. Tnx.
