k icon indicating copy to clipboard operation
k copied to clipboard

Published 20 hours ago • verified publisher icon supercrabtree

[Fix #47] Refactor git checking

Open el1t opened this issue 9 years ago • 4 comments
trafficstars

Speeds up runtime by 20-25%. Addresses issues with supplied git directories (#47)

  • ensure directory can be cd'd into
  • pushd into folders to check for repo
  • run git commands from correct directory
  • check for repo in each base_dir, using $GIT_TOPLEVEL for entire base_dir
  • consolidate git-related (repomarker) code
  • removed use of $IS_GIT_REPO

el1t avatar Jun 02 '16 21:06 el1t

Nice! thanks, will have to find some time to give a proper review, will get on it as soon as possible.

supercrabtree avatar Jun 03 '16 09:06 supercrabtree

No problem, please let me know if anything's against your preferred style!

el1t avatar Jun 03 '16 12:06 el1t

Hey there, just wanted to let you know I hadn't forgotten about this, just been very busy recently. I have just cracked how to do unit tests for k here so I want to get some coverage across the current code, then I will start merging the pull requests I have waiting. Thanks again.

supercrabtree avatar Jul 26 '16 15:07 supercrabtree

No worries, testing looks really neat! By the way, I just figured out how to preserve dirs history with these changes as well.

el1t avatar Jul 26 '16 17:07 el1t