supercollider
Update channel limits and VBAP 1.0.3.2
Adjustments ported from new PD code for VBAP 1.0.3.2. LS amounts allocated dynamically.
Thanks @muellmusik Could you kindly fix formatting to match the rest of the code? And get rid of the whitespace changes? (These can be viewed in the "Files Changed" tab above)
@muellmusik are you planning to make the requested changes or do you suggest pulling this in as is?
Sorry @dyfer, I somehow didn't see these.
Could you kindly fix formatting to match the rest of the code? And get rid of the whitespace changes? (These can be viewed in the "Files Changed" tab above)
Could you be more specific as to what you want me to do? The code is mostly from old PD code and is a big mix of tabs and spaces. I can change line 288 and 290 to be one or the other if that's what you mean, but it won't make things consistent so I'm not sure what's best. Also which formatting would you like changed?
@muellmusik are you planning to make the requested changes or do you suggest pulling this in as is?
I'm okay with that personally. It's a little awkward at the moment as I changed machines and haven't managed to set up a build chain yet (Apple dev license woes...) but I can make changes if need. My personal view is that strict standards for formatting have been dispiriting for some new contributors, and thus aren't really worth it, though I know others have differing views.
Could you be more specific as to what you want me to do? The code is mostly from old PD code and is a big mix of tabs and spaces. I can change line 288 and 290 to be one or the other if that's what you mean, but it won't make things consistent so I'm not sure what's best. Also which formatting would you like changed?
I only would like to avoid changes to lines where the only change is whitespace change (spaces<->tabs typically). You can see them in the "File changed" tab of the GH web UI. Example:
By formatting changes I meant changing indentation, but I only really meant that for the lines where this was the only change in the given line, e.g. line 170/174. Sorry I wasn't clear.
I went through the changes and marked where I can see the whitespace change, if you can't see them for some reason. As I wrote elsewhere, I don't want to block this PR based on the whitespace changes, but I would personally prefer not to have them.
My personal view is that strict standards for formatting have been dispiriting for some new contributors, and thus aren't really worth it, though I know others have differing views.
I don't think this request is about any strict standards. I just didn't think that whitespace-only changes are desired. We don't have automatic formatting set up for sc3-plugins so if you're just pushing back on my request to remove whitespace changes, then that's fine, we can merge with the (unnecessary) whitespace changes. This is an unofficial / semi-official repo anyway.
There have been heated discussions in the past on formatting, but I thought that we are past that... If there is an ongoing discussion about formatting as a substantial issue for new contributors, I'm not aware of it.
@dyfer No worries, I'll fix it thanks for marking. I hope this didn't come off as 'heated' in any way. :-)
Okay @dyfer. I think that's all fixed now. Let me know if there's something more needed. Sorry it took so long.
Thanks @muellmusik I've run this locally and it seems to work (though I'm not sure if the examples from the help file work as they should... in any case, there doesn't seem to be a change from the previous version). Speaking of helpfiles, I noticed that the helpfile also mentions the version of the PD code (in multiple places). Could you update that? Or remove the version number from the help altogether?
Speaking of helpfiles, I noticed that the helpfile also mentions the version of the PD code (in multiple places). Could you update that? Or remove the version number from the help altogether?
Done
(in multiple places).
https://github.com/supercollider/sc3-plugins/blob/topic/vbap-improvements/source/VBAPUGens/sc/HelpSource/Classes/VBAPSpeaker.schelp#L11 https://github.com/supercollider/sc3-plugins/blob/topic/vbap-improvements/source/VBAPUGens/sc/HelpSource/Classes/VBAPSpeakerArray.schelp#L11
EDIT: I guess I should've been specific and write "in multiple files".
If you don't think it's worth changing these, please let me know.
EDIT: I guess I should've been specific and write "in multiple files".
If you don't think it's worth changing these, please let me know.
LOL. I never use this stuff anymore tbh, so my memory of where I wrote such things 15 years ago is a bit fuzzy!
Anyway. Done now. Can we please merge though? haha