connected-react-router icon indicating copy to clipboard operation
connected-react-router copied to clipboard

Published 20 hours ago • verified publisher icon supasate

Github subtitle is misleading

Open JamesGelok opened this issue 3 years ago • 2 comments

The sidebar says: "A Redux binding for React Router v4"

Would it be better to remove the version from this subtitle? Or change it to "A Redux binding for React Router v4 and v5"

Screen Shot 2021-07-03 at 6 19 26 PM screenshot of subtitle

JamesGelok avatar Jul 03 '21 22:07 JamesGelok

It doesn't support React Router v6, so I find the subtitle is quite precise.

sarmad-ajmal avatar Feb 14 '22 09:02 sarmad-ajmal

@sarmad-ajmal I never mentioned v6. In fact, this issue was made before v6 was even released.

It supports v5 though, but the subtitle might imply it only supports v4.

JamesGelok avatar Feb 23 '22 21:02 JamesGelok