plv8 v3.0.0 fails to build for ARM instances

[dragarcia]

Using these steps:

1. Ensure PostgreSQL is installed beforehand.
2. apt install build-essential ca-certificates curl git-core gpp cpp pkg-config apt-transport-https cmake libc++-dev libc++abi-dev libc++1 libglib2.0-dev libtinfo5 libc++abi1 ninja-build python
3. git clone https://github.com/plv8/plv8.git
4. cd plv8 && git checkout v3.0.0
5. make
6. make install

Step 6) make eventually returns an error clang++: error: unknown argument: '-ftrivial-auto-var-init=pattern'

Instance used

• AWS r6g.2xlarge
• Ubuntu 20.04 LTS

Analysis

Changes made to the Makefile in this commit could have most likely affected the build configuration for ARM instances.

Temporary Solution

Reverted back to 3.0.alpha by building from a commit prior to the above commit. This worked as per normal.

[dragarcia]

@burggraf

[inian]

Should we open an issue in the plv8 repo Angelico?

[dragarcia]

got it, just created on here.

[vejja]

Hi @dragarcia Have you been able to build plv8 v3.1.2 ? If yes it would be super exciting to upgrade the plv8 version that is being packaged into the docker image. This would bump the v8 engine version from v7.4 to v9.7, adding many useful modern JS features (e.g. private class methods, optional chaining, nullish coalescing, Array.includes, Intl API, ...)

[Lakshmipathi]

Right now, we are using pretty recent version of plv8 commit (https://github.com/supabase/postgres/blob/develop/ansible/vars.yml#L81) That seems the last commit https://github.com/plv8/plv8/commits/r3.1. I'll go ahead and mark this as resolved. if you disagree, please feel free to re-open or create new issue.