cli
cli copied to clipboard
feat: add HTTP hook Configuration
What kind of change does this PR introduce?
Adds the corresponding configuration for the SendSMS and SendEmail HTTP Hooks. We have decided to use symmetric signing (e.g. v1,whsec_.... ) with one secret per endpoint
Pull Request Test Coverage Report for Build 8998328342
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 26 of 56 (46.43%) changed or added relevant lines in 2 files are covered.
- 10 unchanged lines in 3 files lost coverage.
- Overall coverage decreased (-0.07%) to 57.396%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| internal/utils/config.go | 24 | 37 | 64.86% |
| internal/start/start.go | 2 | 19 | 10.53% |
| <!-- | Total: | 26 | 56 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| internal/storage/rm/rm.go | 2 | 90.48% |
| internal/utils/config.go | 3 | 56.0% |
| internal/gen/keys/keys.go | 5 | 11.76% |
| <!-- | Total: | 10 |
| Totals | |
|---|---|
| Change from base Build 8998220942: | -0.07% |
| Covered Lines: | 6402 |
| Relevant Lines: | 11154 |
💛 - Coveralls
Actually I think we’ll need to wait for the FE/BE/docs to go out before merging :/
New Changes
- Removed the
init_config.toml - Added tests
The backend is now merged and I'm hoping to get this in so that we can allow contributors to write examples for custom SMS providers
How this was tested?
- Without any hooks to ensure it's compatible
- With a hook to ensure it loads as expected