auth
auth copied to clipboard
supabase
fix: fail email sending if email address is empty
Pull Request Test Coverage Report for Build 17242085652
Details
- 3 of 14 (21.43%) changed or added relevant lines in 3 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-0.05%) to 70.753%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| internal/api/external.go | 0 | 3 | 0.0% |
| internal/api/identity.go | 0 | 4 | 0.0% |
| internal/api/mail.go | 3 | 7 | 42.86% |
| <!-- | Total: | 3 | 14 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| internal/api/external.go | 1 | 75.9% |
| <!-- | Total: | 1 |
| Totals | |
|---|---|
| Change from base Build 17191439812: | -0.05% |
| Covered Lines: | 12270 |
| Relevant Lines: | 17342 |
💛 - Coveralls
@hf This still getting merged? Another thing I was thinking about was this should have been caught in https://github.com/supabase/auth/blob/master/internal/mailer/validateclient/validateclient_test.go#L207 - maybe this was sourced from a self-hosted instance that had extended validation disabled?
