auth-js icon indicating copy to clipboard operation
auth-js copied to clipboard

[fix] Call `SIGNED_OUT` event where session is removed

Open bombillazo opened this issue 6 months ago • 7 comments

What kind of change does this PR introduce?

This adds the SIGNED_OUT event missing in some logic that clears/logs out the session.

What is the current behavior?

#853

bombillazo avatar Feb 16 '24 02:02 bombillazo

Any feedback on this @kangmingtay @hf ? We're needing to patch this library whenever a new version is released.

bombillazo avatar Apr 19 '24 12:04 bombillazo

Any updates here?

bombillazo avatar May 08 '24 20:05 bombillazo

Any updates on this, it's breaking our production Electron app, seems that when a request fails, the user just gets signed out entirely.

jczstudios avatar May 22 '24 14:05 jczstudios

Ok, I'll mention @hf so they'll be aware and have visibility on this fix request.

bombillazo avatar May 23 '24 12:05 bombillazo

sorry @bombillazo i was on vacation last week - i'll be looking into this further to see if we can just do away with removing the session prematurely before hitting the underlying auth endpoint - not too sure if it will cause any unintended breaking changes here so we need some time to test this out

kangmingtay avatar May 29 '24 12:05 kangmingtay

@bombillazo i've made a separate PR (#915) to address this - would be great if you can take a look at it too

kangmingtay avatar Jun 05 '24 13:06 kangmingtay

Hey @kangmingtay thanks for the PR, I merged the current repo to my branch and the only thing missing is a few lines of code to emit the SIGNED_OUT event during the _recoverAndRefresh function if the session is ultimately removed.

This means #904 is fixed but #853 is still open.

bombillazo avatar Jun 18 '24 17:06 bombillazo

Any update here? This fixes #853

bombillazo avatar Jul 16 '24 17:07 bombillazo

Hey @kangmingtay , any update on this issue?

bombillazo avatar Aug 06 '24 19:08 bombillazo