auth-js
auth-js copied to clipboard
[fix] Call `SIGNED_OUT` event where session is removed
What kind of change does this PR introduce?
This adds the SIGNED_OUT event missing in some logic that clears/logs out the session.
What is the current behavior?
#853
Any feedback on this @kangmingtay @hf ? We're needing to patch this library whenever a new version is released.
Any updates here?
Any updates on this, it's breaking our production Electron app, seems that when a request fails, the user just gets signed out entirely.
Ok, I'll mention @hf so they'll be aware and have visibility on this fix request.
sorry @bombillazo i was on vacation last week - i'll be looking into this further to see if we can just do away with removing the session prematurely before hitting the underlying auth endpoint - not too sure if it will cause any unintended breaking changes here so we need some time to test this out
@bombillazo i've made a separate PR (#915) to address this - would be great if you can take a look at it too
Hey @kangmingtay thanks for the PR, I merged the current repo to my branch and the only thing missing is a few lines of code to emit the SIGNED_OUT
event during the _recoverAndRefresh
function if the session is ultimately removed.
This means #904 is fixed but #853 is still open.
Any update here? This fixes #853
Hey @kangmingtay , any update on this issue?