auth-js icon indicating copy to clipboard operation
auth-js copied to clipboard

Support id_token grant flow

Open dshukertjr opened this issue 3 years ago • 6 comments

Feature request

Is your feature request related to a problem? Please describe.

A new way of signing users in via OAuth was introduced with this PR of gotrue. It would be nice if we could add a way of utilizing this endpoint with this library so that native apps built with react native could utilize it.

Describe the solution you'd like

OAuth sign in flow on native apps should use POST /token?grant_type=id_token end point to sign in.

Describe alternatives you've considered

Currently OAuth sign in is possible by redirecting the user to web view from a native app.

Additional context

N/A

dshukertjr avatar Nov 07 '21 00:11 dshukertjr

@dshukertjr Hi Tyler, do you know when this feature will be integrated? or do you have a rough timeline? thanks in advance, Andy

megacherry avatar Dec 02 '21 17:12 megacherry

@megacherry Great question!

@kiwicopple Now that the backend is ready for this, do we have anything else that needs to be in place before we add this feature to the client?

dshukertjr avatar Dec 03 '21 03:12 dshukertjr

cc @kangmingtay

phamhieu avatar Dec 16 '21 02:12 phamhieu

@dshukertjr Do you have any new information about this issue? :)

megacherry avatar Jan 06 '22 18:01 megacherry

@kiwicopple @kangmingtay @phamhieu @dshukertjr @megacherry

I have created a pull request that resolves this issue. Please review and merge.

koba-ninkigumi avatar Jan 14 '22 04:01 koba-ninkigumi

It looks like your pr was merged in ? Should this be closed now? @koba-ninkigumi

DanMossa avatar Feb 27 '22 16:02 DanMossa

Closing as this is already supported.

hf avatar Dec 30 '22 16:12 hf