postgrest-py icon indicating copy to clipboard operation
postgrest-py copied to clipboard

fix: used json.dumps instead of str in sanitize_params

Open aduuna opened this issue 3 years ago • 5 comments
trafficstars

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

#131 Use json.dumps instead of str in sanitize_params

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

aduuna avatar Oct 15 '22 19:10 aduuna

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.20%.

Quality metrics Before After Change
Complexity 0.60 ⭐ 0.60 ⭐ 0.00
Method Length 20.75 ⭐ 22.00 ⭐ 1.25 👎
Working memory 3.20 ⭐ 3.20 ⭐ 0.00
Quality 95.25% 95.05% -0.20% 👎
Other metrics Before After Change
Lines 16 18 2
Changed files Quality Before Quality After Quality Change
postgrest/utils.py 95.25% ⭐ 95.05% ⭐ -0.20% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

sourcery-ai[bot] avatar Oct 15 '22 19:10 sourcery-ai[bot]

looks good.

rawandahmad698 avatar Oct 21 '22 15:10 rawandahmad698

Think we might need to update the test cases for this one as well - would be great if someone can jump on - otherwise I'll take a look when there's a free cycle

J0 avatar Jan 23 '23 05:01 J0

Hey,

Going to fix the tests on this one so we can get it in - hope you don't mind!

J0 avatar Feb 11 '23 07:02 J0

This will result in a breaking change at the moment. I've ran the tests and there are too many broken tests to get this into a release.

silentworks avatar Jul 19 '24 10:07 silentworks