postgres-language-server icon indicating copy to clipboard operation
postgres-language-server copied to clipboard

DDL drop type: Server should reognize that composite types dropped with parameters are incorrect

Open Donnerstagnacht opened this issue 7 months ago • 0 comments

Bug report

  • [x] I confirm this is a bug with Supabase, not with my own application.
  • [x] I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

Dropping a composite type with referencing the property types and names is classified correctly as error while referencing the property types only (as with functions) is not detected.

CREATE TYPE if EXISTS group_composite AS (id int, name text);

DROP TYPE if EXISTS group_composite; -- no error => correct
DROP TYPE if EXISTS group_composite (int, text); -- no error => incorrect, should be error: Error: ERROR: 42601: type modifier is not allowed for type "group_composite"

DROP TYPE if EXISTS group_composite (id int, name text); -- error => correct
Image

To Reproduce

  1. Create a type and drop it referencing the parameters (as with functions).

Expected behavior

The server should detect that a type can not be dropped with referenced parameters

As specified in: https://www.postgresql.org/docs/current/sql-droptype.html

System information

  • OS: windows 11
  • editor: vs-code
  • pls: 0.5.0

Donnerstagnacht avatar Apr 22 '25 10:04 Donnerstagnacht