flutter-auth-ui icon indicating copy to clipboard operation
flutter-auth-ui copied to clipboard

FIX Password Reset Flow in SupaEmailAuth

Open henry2man opened this issue 1 year ago • 3 comments

What kind of change does this PR introduce?

FIXES #88

What is the current behavior?

Password reset flow is incomplete in SupaEmailAuth

What is the new behavior?

Successful password reset flow

Additional context

N/A

henry2man avatar Apr 18 '24 09:04 henry2man

Added mounted guards to avoid the usage of BuildContext's across async gaps

henry2man avatar Apr 19 '24 06:04 henry2man

Yeah, second attempt! I was using an older flutter version that didn't trigger the new warnings. Now with 3.19.6 it's working without issues:

% fvm flutter --version
Flutter 3.19.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 54e66469a9 (2 days ago) • 2024-04-17 13:08:03 -0700
Engine • revision c4cd48e186
Tools • Dart 3.3.4 • DevTools 2.31.1

% fvm flutter analyze --fatal-warnings --fatal-infos lib
Analyzing lib...                                                
No issues found! (ran in 0.7s)

@dshukertjr Why don't you use fvm?

henry2man avatar Apr 19 '24 07:04 henry2man

Can anyone take a look here? Thanks ❤️

henry2man avatar May 02 '24 11:05 henry2man

@dshukertjr You're welcome. I still miss some features here (add more possibilities to SignUp flow, more UI tweaks, #32...) so probably I will make more PR in the near future.

henry2man avatar May 13 '24 14:05 henry2man