sup icon indicating copy to clipboard operation
sup copied to clipboard

Fixed issue 1 from eMBee list - changed usage of [email protected] address while replying

Open tradzik opened this issue 10 years ago • 6 comments

https://factor.cc/pad/p/sup-ideas - details about issue

@eMBee ping

tradzik avatar Jan 10 '15 09:01 tradzik

@ty221: Please start using a descriptive title in the header of the pull request as well as more information in the description. Please update the your other PR / issues as well.

gauteh avatar Jan 12 '15 09:01 gauteh

@gauteh Done

tradzik avatar Jan 12 '15 20:01 tradzik

this seems to work, except for cases where the From: header is missing completely. in that case a reply has an empty To: field

eMBee avatar Jan 17 '15 19:01 eMBee

@eMBee can't reproduce. When From in header is missing and there is only one recepient (me), it shows only customized view. Where there are multiple people, it shows two views: customized and recepient. Customized is empty, recepient imports emails propely

tradzik avatar Jan 17 '15 22:01 tradzik

try with a different recipient, not you. try with multiple recipents in the To: header

eMBee avatar Jan 18 '15 06:01 eMBee

I think name = "Sup Auto-generated Fake Sender <[email protected]> in message.rb should be made a class constant (split into name and email) and then referenced in that way both in message.rb and in your code, also, it would be nice to grep the rest of the code base to see if it should be replaced somewhere else.

gauteh avatar Jan 18 '15 10:01 gauteh