sup icon indicating copy to clipboard operation
sup copied to clipboard

Implemented 45th eMBee's idea - info in label-search-results-mode about amount of all threads and these unread ones

Open tradzik opened this issue 10 years ago • 11 comments

https://factor.cc/pad/p/sup-ideas

@eMBee ping

tradzik avatar Jan 03 '15 10:01 tradzik

crashes when selecting "unread" from label list status line takes to much space, should fit in 80 chars or less do we need to consider configurability?

eMBee avatar Jan 04 '15 07:01 eMBee

@eMBee done and fixed

tradzik avatar Jan 04 '15 09:01 tradzik

you fixed the crash, but the status line still takes to much space. please find a way to make the status display more compact

eMBee avatar Jan 13 '15 17:01 eMBee

code-in task closed as: http://www.google-melange.com/gci/task/view/google/gci2014/5874253899497472

eMBee avatar Jan 18 '15 14:01 eMBee

we have gone over this again, and i believe it is ready to be merged into develop. since it enhances the UI i can't think of any test that would fit.

eMBee avatar Feb 16 '15 17:02 eMBee

Have you been running sup with these changes applied for a while to test them?

gauteh avatar Feb 18 '15 18:02 gauteh

@gauteh I am using those changes and I didn't met any error while running them.

tradzik avatar Feb 18 '15 18:02 tradzik

Excerpts from Tymon Radzik's message of 2015-02-18 19:36:24 +0100:

@gauteh I am using those changes and I didn't met any error while running them.

i am running all ty221 branches merged since this week.

eMBee avatar Feb 18 '15 19:02 eMBee

@eMBee: I added you to the committers team, could you merge this PR together to a few meaningful commits (we don't need all sub-fixes and review-fixes, I typically use git rebase -i for this) and push it to the develop branch? Make a test branch on your repository first if you want me to review it first.

gauteh avatar Feb 18 '15 20:02 gauteh

let me retract that, this needs more work: i just noticed that the numbers don't seem to get updated when new messages are added or read.

@ty221: could you look into that please?

eMBee avatar Feb 19 '15 18:02 eMBee

@eMBee Ok, I didn't meet this problem before, .. Please give me some time to analyse it and eventually fix.

tradzik avatar Feb 22 '15 14:02 tradzik