Michael Suo

sorry for the late response—I ran the CI, mind taking a look at the issues?

Can you give me permission to push to your branch? I want to try rebasing to see if that fixes things

@ezyang are we not expecting this to completely explode meta infra?

yeah…it's looking pretty rough on Meta's internal monorepo. This PR will need a pretty committed champion who is a Meta employee to be mergeable. @malfet, @ezyang: any nominees?

Seems reasonable. My only concern is that stuff like `self.eps: int = …` are a pretty common thing to put on a module, which I guess this change would cause...

Oh I see. I was misunderstanding how getattr annotation worked. In that case, let’s go for it. On Mon, Jan 22, 2024 at 7:38 AM Jez Ng ***@***.***> wrote: >...