Xianda Sun
Xianda Sun
Oops, sorry for forgetting about this. I'll take a look tomorrow morning.
Small technical question: am I reading it correctly that AdvancedVI right now uses the linear parametrization?
@alexandrebouchard could you trigger the CI again?
@alexandrebouchard sorry for taking a bit of time on this one. Could you add me as a contributor so CI can trigger automatically? No pressure, happy to push this forward...
Tests other than MPI should be passing. The issue with MPI stems from that, `JuliaBUGS.BUGSModel` has [a field](https://github.com/TuringLang/JuliaBUGS.jl/blob/53fd7bb5b69ae7d0045ee3231c5793e2f4811c9c/JuliaBUGS/src/model/bugsmodel.jl#L122) stores a function that is `Base.eval`ed at compile time. This function perform...
Thanks Alex! Yeah, I was able to fix the MPI issue with similar approach as you suggested in https://github.com/Julia-Tempering/Pigeons.jl/pull/364#issuecomment-3386345729. A hiccup is that `BUGSModel` use the generated function as a...
The tests pass, I think this is good for a review
Absolutely, will take a look.
Taking a look today
This is a great effort, @torfjelde, thanks a lot. Some questions for my own understanding: - I was and am still a bit confused by what `transform` and `link` mean...