py360convert icon indicating copy to clipboard operation
py360convert copied to clipboard

Numba Support

Open Skylion007 opened this issue 5 years ago • 1 comments

With some rewriting to support Numba, this library could be even faster. It would require a bit of refactoring, but it might make the code even faster and unlocks the ability to use fastmath, autoparallelilzation and other features.

The jit_module function from numba gets you part of the way there, but there were several parts of the functions like c2e that needs to be rewritten into smaller functions or slightly modified to use the supported functions in numpy.

Skylion007 avatar Sep 02 '20 14:09 Skylion007

That would be great

swell-d avatar Sep 18 '24 12:09 swell-d

I'm open to PRs if someone wants to take a stab at this!

BrianPugh avatar Dec 16 '24 01:12 BrianPugh

I did a first stab at this in the numba branch, but it didn't yield faster code. I'm not particularly well experienced in numba, so other eyes on this would be appreciated.

BrianPugh avatar Dec 20 '24 18:12 BrianPugh

I did a bunch of optimization in #38. It should be a little bit faster with a vanilla install, but it should now be several times faster if opencv is installed. I think this takes away a lot of the attractiveness of a numba-implementation low. Closing for now!

BrianPugh avatar Dec 21 '24 20:12 BrianPugh