djoser icon indicating copy to clipboard operation
djoser copied to clipboard

added settings to customize activation mail sending

Open Chadys opened this issue 5 years ago • 3 comments

I think applications should be able to customize the users' activation procedure for their use cases. In the current version, when you want activation upon registration you also get activation upon email and username change which might not be desired. I added two settings, ACTIVATION_NEEDED_ON_EMAIL_UPDATE and ACTIVATION_NEEDED_ON_USERNAME_UPDATE that enable to customize on what event an activation is needed. They are both set to True by default, so as to keep current behaviour. The SEND_ACTIVATION_EMAIL documentation was also missing the activation on username change.

Chadys avatar Jun 17 '19 12:06 Chadys

Codecov Report

Merging #401 into legacy will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           legacy     #401   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files          19       19           
  Lines         699      699           
=======================================
  Hits          683      683           
  Misses         16       16
Impacted Files Coverage Δ
djoser/conf.py 96.87% <ø> (ø) :arrow_up:
djoser/serializers.py 96.82% <100%> (ø) :arrow_up:
djoser/views.py 99.27% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ebdd2f2...3d208f5. Read the comment docs.

codecov[bot] avatar Jun 17 '19 12:06 codecov[bot]

Hey, this PR looks like it was force-pushed to the master branch and then the base was moved to legacy. I couldn't find the code that was changed on the master branch. Is there any chance of this getting merged in soon?

Thanks!

BrendanMyers88 avatar Aug 21 '20 19:08 BrendanMyers88

Hello, I made this just before version 2.0 came out and it was too late to include my changes in a last 1.X by then. I need to update this PR to become compatible with current djoser version, but I didn't have anymore time to do it then and I still don't have now. Feel free to fork my work and propose your own, up-to-date, PR for that feature. Else I can't guarantee when I'll have enough free time to get back to it.

Chadys avatar Apr 25 '21 12:04 Chadys