ndcube icon indicating copy to clipboard operation
ndcube copied to clipboard

Published 20 hours ago • verified publisher icon sunpy

Skip plotting line data if it's all NaNs

Open SolarDrew opened this issue 10 months ago • 1 comments
trafficstars

Closes DKISTDC/dkist#477

Over in the DKIST python tools I discovered that trying to line plot a slice of a dataset took many times longer if there was no actual data there. This skips the attempt to actually plot a line full of NaNs which should solve that and cause no other problems anywhere, probably.

SolarDrew avatar Jan 07 '25 13:01 SolarDrew

~~This will break if the data aren't a dask array, so that's not ideal.~~

SolarDrew avatar Jan 07 '25 14:01 SolarDrew

Hi @SolarDrew. What's the status of this PR? Would you still like to merge it?

DanRyanIrish avatar May 14 '25 11:05 DanRyanIrish

Sorry, I forgot this was blocked on me. Yes, I'd still like it merged, I'll come back and have a look at it soon.

SolarDrew avatar May 15 '25 10:05 SolarDrew