ablog icon indicating copy to clipboard operation
ablog copied to clipboard

Fix sidebars ablog translations (#80)

Open luis-henrix opened this issue 2 years ago • 6 comments

This pull-request includes 2 commits:

  • The first one is an attempt to fix issue #80 although I'm really new to this sort of things (I've never hear of jinja before!)
  • The second commit is simply the translation to Portuguese.

I'm leaving this as a draft pull-request. Comments are welcome.

luis-henrix avatar Oct 02 '22 21:10 luis-henrix

Hmm.. there's a failure in the PR checks. Any idea what that means?

luis-henrix avatar Oct 02 '22 21:10 luis-henrix

You can ignore sunpy.ablog (Stage 3 Tests py310-sphinxdev [linux]), that is something I need to fix.

For pre-commit.ci that means the PR has failed the style check, that can be fixed automatically by a bot if you so desire. Otherwise you will want to run the pre-commit locally.

nabobalis avatar Oct 02 '22 22:10 nabobalis

Thanks for the PR! I can test it if you want to see if it works? Is there something else you want do before this is ready?

nabobalis avatar Oct 02 '22 22:10 nabobalis

Thanks for the PR! I can test it if you want to see if it works?

Yes, please do test it. Any feedback is welcome as this is something out of my comfort zone :-)

Is there something else you want do before this is ready?

Actually, I had another local change I forgot to commit. Unfortunately, I won't be able to do that now -- I'll try to push it later today. It's simply an update to the documentation, that needs to be updated.

luis-henrix avatar Oct 03 '22 07:10 luis-henrix

Is there something else you want do before this is ready? Actually, I had another local change I forgot to commit. Unfortunately, I won't be able to do that now -- I'll try to push it later today. It's simply an update to the documentation, that needs to be updated.

Take your time, there is no need to rush here!

nabobalis avatar Oct 03 '22 13:10 nabobalis

Ok, I've just pushed the extra change I had. It's a trivial change, I believe. Just update documentation to use the correct file paths.

Please let me know if you see any issues with this pull-request, specially with the commit that fixes issue #80 which is the one I'm less comfortable with.

luis-henrix avatar Oct 03 '22 20:10 luis-henrix

Sorry for not getting back sooner, as far as I can tell, it works!

Thank you very much.

nabobalis avatar Nov 14 '22 23:11 nabobalis