node-geohash icon indicating copy to clipboard operation
node-geohash copied to clipboard

add geohashBase4 method as issue #30

Open ppKrauss opened this issue 7 years ago • 3 comments

main change was from if (bits === 5) to if (bits === maxBits).

ppKrauss avatar Nov 28 '18 10:11 ppKrauss

By making a new encodeBase4, I don't want to change the signature of current encode for bringing in incompatible change.

I suggest to refactoring the code to support base4 encoding.

Also please add the space between operators. And add {} to of else for consistency of coding style.

sunng87 avatar Nov 28 '18 13:11 sunng87

By making a new encodeBase4, I don't want to change the signature of current encode for bringing in incompatible change.

I not see "default undefined" as a incompatible change.

I suggest to refactoring the code to support base4 encoding.

... Better you do what you whant...

Also please add the space between operators. And add {} to of else for consistency of coding style.

OK. (I think it is possible to enforce style with travis.yml)

ppKrauss avatar Nov 28 '18 14:11 ppKrauss

Hi, some news here?

ppKrauss avatar Dec 04 '18 07:12 ppKrauss