handlebars-rust icon indicating copy to clipboard operation
handlebars-rust copied to clipboard

Improve stability of the benchmark

Open darnuria opened this issue 2 years ago • 2 comments

Some benches were not totally stable on my computer (it's really hot these days, maybe I hit the temp freq switch of my cpu in the benches)

But on some case maybe black boxing and increasing the measurement (now 100 by default) is a start:

doc of criterion black_box: https://docs.rs/criterion/latest/criterion/fn.black_box.html

darnuria avatar Aug 02 '22 20:08 darnuria

Our benchmark is highly CPU-intensive, so the condition of your system and CPU throttle matters. Could you please verify if block_box really help?

sunng87 avatar Aug 03 '22 01:08 sunng87

Hi, thanks for the reply, it passed under the radar, may have some time to do some tests this week with/without black-box on personnal and work computers.

darnuria avatar Aug 23 '22 21:08 darnuria

Sorry will close for inactivity didn't found time to work on it. And since I didn't provided "strong" fact better just close it. :)

darnuria avatar Mar 31 '23 10:03 darnuria