Ning Sun comments

Results 315 comments of


                                            Ning Sun

Update docs for feat: change the default selector to RoundRobin

Also we need to update https://docs.greptime.com/contributor-guide/metasrv/selector to add description about round robin

Parametrize the rate limiter with `sleep-fn`

@marksto Thank you for the patch. Overall this looks good to me. I will take a look deep into the detail tomorrow when I find time.

Parametrize the rate limiter with `sleep-fn`

This looks good to me. I hope you can include some other candidates of `sleep-fn` impl to build into the library. And for the rollback function, are you going to...

Parametrize the rate limiter with `sleep-fn`

@marksto Sounds good. We can have: - normal sleep (Thread/sleep) - rollback-able sleep - uninterrupt-able sleep

Parametrize the rate limiter with `sleep-fn`

@marksto Thank you! The patch looks good to me.

Parametrize the rate limiter with `sleep-fn`

Just uploaded 0.12.0. Let me know if there is any issue. Thank you for the patch!

Streaming body issue with a synchronous ring handler

Back to servlet spec, it does not allow async thread to write to `HttpServletResponse` outside handler methods of `HttpServlet`. Jetty has flexible requirement for this but it requires a callback...

Implement block-scoped inline partials

@YannikSc thank you for the patch. I'm so sorry for the delay of review. I'm getting super busy these days and I will find time to look into this.

feat: add respective `json_is` UDFs for JSON type

Do you think it will be a good idea to have `jq` as a built-in function? I think it can cover most JSON operations so we don't have to implement...

Floating point (f32) within a struct renders incorrecly

Hello @JonoPrest That's how floating point numbers work. You hardly get a very precise one. Typically you can use a format string like "{:.2}" for that