sunmy2019

So I inlined all those functions manually. Found it keeps warning the following code snippets. https://godbolt.org/z/Y3E5fh9G6 ```cp if (num_chars_left > 0 && num_chars_left < block_size) { char buf[2 * block_size...

I carefully reads through the logic and decide it should be a false positive. Maybe we will need a hack to suppress that compiler warning.

> It does look like false positive so might be worth reporting to gcc but I applied a workaround in [0379bf3](https://github.com/fmtlib/fmt/commit/0379bf3a5d52d8542aec1874677c9df5ff9ba5f9). Yeah, but it's a temporary workaround. The same warning...

`time` crate needs a bump from 0.3.34 to 0.3.36. https://github.com/rust-lang/rust/pull/124736 --- Already done in the trunk, waiting for the next release.

Can you elaborate more on the output and the error? Also an error here: ```diff try { fmt::println("{:s}", ex.code()); fmt::println("{}", ex.code().message()); - } catch (std::exception e) { + } catch...

The question could be rephrased as: > Formatter of `std::error_code` does not handle non-UTF-8 encoding with `s` spec. Maybe we can add a wrapper to convert `ec.message()` to UTF-8.

related issue: https://github.com/fmtlib/fmt/issues/4125