turtle icon indicating copy to clipboard operation
turtle copied to clipboard

Battleship board game implementation in Turtle

Open sathwikmatsa opened this issue 2 years ago • 3 comments

This PR adds battleship board game implementation to turtle examples - #23

  • [x] single player mode
  • [x] multiplayer mode
  • [x] arrow keys & enter based controls

sathwikmatsa avatar Jul 24 '21 14:07 sathwikmatsa

Firstly - I don't have commit rights here!

I did not really read the whole code. But at a first glance, I think it would be nice to have some more documentation - as the examples are made to be read for learning. The audience is less experienced and is often very happy for explaining comments - so an overview in main.rs over the code might be helpful, as well as some function documentations for the less obvious things...

That said, the game itself looks great!

enaut avatar Jul 24 '21 18:07 enaut

Hey @enaut, Thanks for your feedback. I've added some documentation as per your suggestion. Let me know if you have any comments.

sathwikmatsa avatar Jul 27 '21 12:07 sathwikmatsa

Thanks for taking the time to contribute this example! Appreciate the first pass at reviewing @enaut. I have been swamped with things at work lately but hopefully I will have time to review this in the coming week. If I don't get to it by next weekend, please ping me. Sorry for the delay!

sunjay avatar Aug 04 '21 23:08 sunjay