turtle icon indicating copy to clipboard operation
turtle copied to clipboard

Upgrade to tokio 1.0

Open sunjay opened this issue 4 years ago • 0 comments

This PR updates from tokio 0.2 to tokio 1.0.

To-do

Currently blocked on the following:

  • [x] UnboundedReceiver::blocking_recv - PR merged, needs to be released in the next release after 0.3.5
  • [ ] Need Handle::block_on (https://github.com/tokio-rs/tokio/issues/3096, PR https://github.com/tokio-rs/tokio/pull/3097) or something to replace it when we block on the process exiting in Drop implementations https://github.com/sunjay/turtle/blob/79635eab8a05b64ee8a2a3ec1265f65fb2fd124d/src/renderer_server/backend/multithreaded.rs#L91 https://github.com/sunjay/turtle/blob/79635eab8a05b64ee8a2a3ec1265f65fb2fd124d/src/renderer_server/backend/multiprocessed.rs#L146
  • [ ] Need UnboundedReceiver::try_recv to be added back - https://github.com/tokio-rs/tokio/issues/3350
    • Might be able to replace it with a sync channel (we only ever call try_recv and send, so nothing is blocking)
  • [ ] Check to make sure we're using the latest version of tokio
  • [ ] Resolve warnings, make sure tests still pass, and run a few examples to make sure everything still works

sunjay avatar Dec 14 '20 00:12 sunjay