Sun S. D. Tan

Results 92 comments of Sun S. D. Tan

I am going to provide a fix to `OpenShiftBuildTask.java`: ``` diff --git a/gradle-plugin/openshift/src/main/java/org/eclipse/jkube/gradle/plugin/task/OpenShiftBuildTask.java b/gradle-plugin/openshi> index ef0f8b0c..03d66aec 100644 --- a/gradle-plugin/openshift/src/main/java/org/eclipse/jkube/gradle/plugin/task/OpenShiftBuildTask.java +++ b/gradle-plugin/openshift/src/main/java/org/eclipse/jkube/gradle/plugin/task/OpenShiftBuildTask.java @@ -31,6 +31,7 @@ public class OpenShiftBuildTask extends KubernetesBuildTask...

ok after debugging with @manusa finally the fix is ``` diff --git a/gradle-plugin/kubernetes/src/main/java/org/eclipse/jkube/gradle/plugin/task/AbstractJKubeTask.java b/gradle-plugin/kuberne> index f2085b10..259fff03 100644 --- a/gradle-plugin/kubernetes/src/main/java/org/eclipse/jkube/gradle/plugin/task/AbstractJKubeTask.java +++ b/gradle-plugin/kubernetes/src/main/java/org/eclipse/jkube/gradle/plugin/task/AbstractJKubeTask.java @@ -152,6 +152,7 @@ public abstract class AbstractJKubeTask extends...

Now deploying `quickstarts/gradle/webapp-wildfly`: ``` 09:17:21,123 INFO [org.jboss.weld.Version] (MSC service thread 1-2) WELD-000900: 3.1.8 (Final) 09:17:21,513 ERROR [org.jboss.as.controller.management-operation] (Controller Boot Thread) WFLYCTL0013: Operation ("deploy") failed - address: ([("deployment" => "ROOT.war")]) -...

I managed to get rid of these errors by passing manually `GALEON_PROVISION_LAYERS=datasources-web-server` Now I get the JBoss Wildfly main page instead of the app :/

This is strange because: https://github.com/eclipse/jkube/blob/master/jkube-kit/generator/webapp/src/main/java/org/eclipse/jkube/generator/webapp/handler/WildFlyAppSeverHandler.java#L109 ``` @Override public Map getEnv() { // Applicable for s2i image - ignored for Docker return Collections.singletonMap("GALLEON_PROVISION_LAYERS", "cloud-server,web-clustering"); } ``` But I am not sure...

looks like it doesn't work, `GALLEON_PROVISION_LAYERS=cloud-server,web-clustering` should be passed to the build config where it looks like here it is env for the final built image.

Absolutely, but `k8s:resource` is very tight to `k8s:apply` and `k8s:build` to `k8s:push`, etc. It is about putting things together and simplifying navigation, searching and learning. In inner or outerloop, I...

@pmbsa Is this working for you? Can we close this issue? Thanks

ok so i think i understand: - kubernetes build is local docker build - openshift build with docker strategy is remote docker build (in the openshift cluster) but having say...

this part is wrong: ![Selection_662](https://user-images.githubusercontent.com/650571/171190199-d36efd23-7d5f-46e3-8799-96a616207189.png) - It is assuming that it will perform a docker build locally which is wrong. - it is assuming that docker is the default strategy...