data-anonymization icon indicating copy to clipboard operation
data-anonymization copied to clipboard

Slow, callbacks, validations

Open krainboltgreene opened this issue 10 years ago • 2 comments

Hey @sunitparekh, I've been looking at your gem. I like the fluent-language a lot!

However I have some suggestions:

  1. It runs #each instead of #find_each, which is significantly faster.
  2. It doesn't allow for the user to skip callbacks.
  3. It doesn't allow for the user to skip validations.
  4. It loads the AR model into memory

All of these things will make the anonymization process slow. My company is about to release a gem we could integrate, called active_record-write. It would make operations faster by a significant amount. Thoughts?

krainboltgreene avatar Dec 16 '15 23:12 krainboltgreene

Thanks a lot for suggestions and happy to make it better. Send me a pull request with changes you are suggesting and I will look into those and do the necessary which can help make tool better.

On Thu, 17 Dec 2015 at 4:58 AM, Kurtis Rainbolt-Greene < [email protected]> wrote:

Hey @sunitparekh https://github.com/sunitparekh, I've been looking at your gem. I like the fluent-language a lot!

However I have some suggestions:

  1. It runs #each instead of #find_each, which is significantly faster.
  2. It doesn't allow for the user to skip callbacks.
  3. It doesn't allow for the user to skip validations.
  4. It loads the AR model into memory

All of these things will make the anonymization process slow. My company is about to release a gem we could integrate, called active_record-write. It would make operations faster by a significant amount. Thoughts?

— Reply to this email directly or view it on GitHub https://github.com/sunitparekh/data-anonymization/issues/28.

sunitparekh avatar Dec 17 '15 05:12 sunitparekh

Points 2 and 3 are fixed by https://github.com/sunitparekh/data-anonymization/pull/57

JasonBarnabe avatar Apr 13 '18 19:04 JasonBarnabe