sungchun12
Feature/set preview limit
Added the set preview limit, worked as far as I've tested it
Removed redundant call of setup_logger() as it was resulting in triplicated logging output. ie everything that was logged after it, was printed 3 times.
Cool I'll take a deeper look at this on Monday! Thanks for the PR. Love that we're evolving this together :)
The preview limit isn't working for me because from fst.config_defaults import CONFIG on L20 is read by the query_handler.py before it can be reset with the --preview-limit flag. I recommend following some general guidance from GPT4 below that'll point you in the right direction.
I'm going to hold off on merging this until 4/19 because I want to present a couple wild features to my company on 4/18. I'll give you a shoutout for all your help!
sounds good to me! thanks a lot for the shoutout :) I'm traveling at the moment so out of the working routine but will be back next week to make some more progress. good luck with the presentation!
The preview limit isn't working for me because
from fst.config_defaults import CONFIGon L20 is read by thequery_handler.pybefore it can be reset with the--preview-limitflag. I recommend following some general guidance from GPT4 below that'll point you in the right direction.
This is strange as well. It's working on WSL and it's working in Codespaces as well as expected. I'm still updating to your suggestion, it's indeed a bit cleaner
Added a bunch of changes and should be ready for review. The duplicated log outputs should be resolved by a check in setup_logger() for an already existing handler. rows_preview_limit is passed through to the query handler without setting config variable
Can you show me a screenshot of this working?
I can't get it to work at all with or without the preview flag: fst start fst start --preview-limit 10.
Please resolve the conflicts of the files above listed by Github!