You have requested a synthetic service ("request")

Open vortexgin opened this issue 9 years ago • 1 comments

Dear Admin,

Today i found some bug on your repository when i'm update my dependencies on symfony 2.8. Your argument on mobile_detect.twig.extension service using deprecated service, i have change your repository on my local. Here's the change : <service id="mobile_detect.twig.extension" class="%mobile_detect.twig.extension.class%"> <argument type="service" id="mobile_detect.mobile_detector" /> <argument type="service" id="mobile_detect.device_view" /> <argument>%mobile_detect.redirect%</argument> <call method="setRequest"> <argument type="service" id="request" on-invalid="null" strict="false" /> </call> <tag name="twig.extension"/> </service>

into

<service id="mobile_detect.twig.extension" class="%mobile_detect.twig.extension.class%"> <argument type="service" id="mobile_detect.mobile_detector" /> <argument type="service" id="mobile_detect.device_view" /> <argument>%mobile_detect.redirect%</argument> <call method="setRequest"> <argument type="service" id="request_stack" on-invalid="null" strict="false" /> </call> <tag name="twig.extension"/> </service>

Please update your config or change your minimum dependencies.

Aug 29 '16 15:08 vortexgin

Since this bundle depends on FrameworkBundle 2.4 or higher making use of the request stack instead of injecting the request service looks like a reasonable solution to me.

Sep 03 '16 10:09 xabbuh