MobileDetectBundle icon indicating copy to clipboard operation
MobileDetectBundle copied to clipboard

Why not handle ESI?

Open borisguery opened this issue 11 years ago • 1 comments

Having experienced an issue with an ESI request, I took a quick look at the code and I realized that the listener ignores sub-requests (used by ESI).

There: https://github.com/suncat2000/MobileDetectBundle/commit/444e595d1eb0b2f8d83f395100c8db7e2cc868cf#diff-1ef8ac159e28a851a5ada1b954455703R72

I'm wondering why? It looks inconsistent to me because I would expect to be allowed to use issers methods in the same way to render a consistent views/layouts.

borisguery avatar Nov 12 '13 15:11 borisguery

Probably because the most common case is that people want to ignore ESI... It could be configurable though - try submitting a PR for it if you still need it :)

ricoli avatar Jan 13 '14 13:01 ricoli