MobileDetectBundle icon indicating copy to clipboard operation
MobileDetectBundle copied to clipboard

Abandoned in favor of `tattali/mobile-detect-bundle`

Open tattali opened this issue 3 years ago β€’ 3 comments

Hi everyone,

Given the lack of responsiveness of this bundle author, I decided to create and maintain a fork tattali/MobileDetectBundle.

The fork is available now and you will find instructions for using it in the README.

Of course, if you are ready to help, do not hesitate to contact me!

If you have any question, don't hesitate to ask! πŸ‘

What have been done so far:

Highlights

  • Full compatibility with Symfony 3.4 to 6
  • Rework README.md to clarify the meaning of the bundle
  • Maintain test coverage to 94%
  • Create MobileDetectorInterface interface of Mobile_Detect class
Full details

Documentation

  • Rework README.md to clarify the meaning of the bundle
  • Create a new logo with mobile detect and symfony bundle

CI

Configuration

  • Convert services to YAML files
  • Use class names as ids in services to respect new best practices and alias to old ids
  • Rename mobile_detect.cookie_httponly to mobile_detect.cookie_httpOnly
  • Drop mobile_detect.mobile_detector.class, mobile_detect.device_view.class, mobile_detect.request_response_listener.class, mobile_detect.twig.extension.class

Improvements

  • Create MobileDetectorInterface interface of Mobile_Detect fully compatible with mobiledetect/mobiledetectlib >=2.8.15
  • Create MobileDetectBundle\DeviceDetector\MobileDetectorInterface service to quickly access the lib
  • Add an is_windows_os in the twig extension
  • Add an rules_list in the twig extension

Drops

  • Drop active support for Symfony <5.1 see Legacy version to use the bundle
  • Drop support for PHP <7.2.5
  • Drop support for mobiledetect/mobiledetectlib <2.8.15
  • Drop support for Symfony 2.8 and <3.4 (non flex version)
  • Drop psr-0 in favour of psr-4 and rename namespace as neutral MobileDetectBundle\

Others

  • Move the Main bundle to src and tests to tests folders
  • Add small Makefile
  • Enable active support of mobiledetect/mobiledetectlib >= 2.8.15
  • Clean php-doc with php8 compatible types and remove unnecessary documentation
  • Add native php typing where it’s possible
  • Rename cookieSamesite by cookieSameSite in whole project

Planned work for next release:

  • Continue the rework of the documentation
  • Test and document all the features of the bundle (redirection...)
  • Ensure the compatibility with Symfony6 and future version
  • Create a dedicated recipe
  • Review and integrate the pending issues and PR of the main repo to the fork
  • Create a edge version Compatible with PHP >=8.0, Symfony >=6.0 and MobileDetect php7.4

EDIT: Every features documented in the README are working at full capacity Do not hesitate to open an issue if you found a bug.

Enjoy! πŸ‘ πŸ‘

tattali avatar Apr 07 '22 05:04 tattali

@suncat2000 Would you consider to abandon the package suncat/mobile-detect-bundle in favor of tattali/mobile-detect-bundle on packagist please? Don't hesitate to contact me if you want to discuss about this. https://packagist.org/packages/suncat/mobile-detect-bundle

tattali avatar Apr 08 '22 16:04 tattali

There is already continued package.. netbull/mobile-detect-bundle

netbull avatar Jul 07 '22 07:07 netbull

Hi @netbull, Yeah I saw that you started a continued package, but I thought it was also inactive since it didn't work with Symfony 6.

tattali avatar Jul 07 '22 15:07 tattali