MobileDetectBundle icon indicating copy to clipboard operation
MobileDetectBundle copied to clipboard

Symfony 3.3 deprecated service declaration

Open fdespier opened this issue 8 years ago • 2 comments

Hi @suncat2000,

Autowiring services based on the types they implement is deprecated since Symfony 3.3 and won't be supported in version 4.0.You should rename (or alias) the "mobile_detect.device_view" service to "SunCat\MobileDetectBundle\Helper\DeviceView" instead.

What do you think to make a new branch 2.X to handle new version of Symfony (>3.4) ?

fdespier avatar Jul 04 '17 12:07 fdespier

:+1:

20uf avatar Jul 07 '17 11:07 20uf

Do you really want to maintain two branches just to avoid some if conditions inside the DI extension class? I don't think that's worth it.

xabbuh avatar Jul 07 '17 11:07 xabbuh