shadcn_flutter icon indicating copy to clipboard operation
shadcn_flutter copied to clipboard

Inconsistences with colors in colorScheme

Open JCKodel opened this issue 9 months ago • 1 comments

Image

The chevron (>) has a theme.colorScheme.muted color. The number 1 has a .textMuted().

In this case, the textMuted has nothing to do with the colorScheme.muted (I can't even find from where that color comes from).

So, I editted the colorScheme to make the muted color red and the border color blue.

Image

The card actually has muted color as the border O.o

To fix that:

  1. textMuted() should get its color from colorScheme.muted
  2. colorScheme.muted should be darker (the same color that textMuted())
  3. Components (card, tabs, etc.) are getting colorScheme.muted for its border, but it should be colorScheme.border.

Also, would be nice to simplify the colorScheme:

  1. What is the point of primary, accent and ring if they are all the same?

  2. what is input?

JCKodel avatar Mar 28 '25 02:03 JCKodel

I'm just following the original color scemes https://github.com/shadcn-ui/ui/blob/main/apps/www/registry/registry-base-colors.ts If it's inconsistent, its probably because its outdated, most of the components are just direct port from old version, I cant always keep up with the newer release of shadcn ui.

also i think textMuted uses the correct style (text-muted-foreground) as per the original source https://ui.shadcn.com/docs/components/typography#Muted

and input actuallly used as border for outline button in the original source, but i think i changed it to border instead https://github.com/shadcn-ui/ui/blob/754a66061d104750c2fcd7ac294f856b99832692/apps/www/registry/new-york/ui/button.tsx#L16-L17

i can make a small tweak to these components to use the right colors, but i can't change the color schemes since its generated, just let me know which component has the wrong color

sunarya-thito avatar Mar 28 '25 03:03 sunarya-thito