circuit-ui icon indicating copy to clipboard operation
circuit-ui copied to clipboard

Add actions prop to NotificationInline

Open a5e opened this issue 2 years ago • 5 comments

Purpose

Adds the possibility to have multiple actions in a NotificationInline component.

Internal link to the design discussion in Figma

Approach and changes

  • Add an actions prop (actions and action are mutually exclusive)

Definition of done

  • [ ] Development completed
  • [ ] Reviewers assigned
  • [ ] Unit and integration tests
  • [ ] Meets minimum browser support
  • [ ] Meets accessibility requirements

a5e avatar Apr 24 '23 15:04 a5e

Hey @a5e, we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

sumup-clark[bot] avatar Apr 24 '23 15:04 sumup-clark[bot]

⚠️ No Changeset found

Latest commit: 0c4c1ce4029b60a724f54387cd8d2f0d303a91e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 24 '23 15:04 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview Apr 24, 2023 3:40pm

vercel[bot] avatar Apr 24 '23 15:04 vercel[bot]

Codecov Report

Merging #2062 (0c4c1ce) into main (a62c441) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2062   +/-   ##
=======================================
  Coverage   92.16%   92.17%           
=======================================
  Files         168      168           
  Lines        3537     3539    +2     
  Branches     1224     1226    +2     
=======================================
+ Hits         3260     3262    +2     
  Misses        256      256           
  Partials       21       21           
Impacted Files Coverage Δ
...mponents/NotificationInline/NotificationInline.tsx 93.22% <100.00%> (+0.23%) :arrow_up:

codecov[bot] avatar Apr 24 '23 15:04 codecov[bot]

We're putting this change on hold until we have time to document some usage guidelines for the multi-button variant.

connor-baer avatar Jun 02 '23 14:06 connor-baer