Peter Gorniak

Results 47 comments of Peter Gorniak

I think we should just make sure that any translation can be done incrementally without having to provide content for all the files. So if you just specify card set...

Hi, thanks for helping out! You would need to [create a Pull Request from your fork to the repo](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork).

The test is telling you that your JSON format is not valid: `card_db_src/de/cards_de.json: Failed to json decode (Expecting ',' delimiter: line 2868 column 1 (char 451824))`. I recommend producing the...

See #148 for a contribution from a BGG user. I think we should talk about whether these should be in a separate list/option - I feel they should be.

I made some comments on #148 - I think we should provide a way to turn off official expansions, like `--expansions=none`, default the fan expansion selection to that value, and...

The PR (#409) is actually merged so you can already use the script on master for these. I just haven't updated the online generator.

Ok, this is deployed.

Cool, @wvoigt might be the right person to review if they have time, otherwise I will.

Actually, it looks like there's might be a more acceptable solution in https://github.com/bw2/ConfigArgParse since the last time I looked.