summernote icon indicating copy to clipboard operation
summernote copied to clipboard

Pop-up heights have been adjusted to match the content.

Open aliyilmaz opened this issue 2 years ago • 2 comments

What does this PR do?

Resize the popup window according to the content.

Where should the reviewer start?

  • start on the src/styles/lite/scss/modal.scss
// Scale up the modal
@media (min-width: 768px) {
  // Automatically set modal's width for larger viewports
  .note-modal-content {
    width: 600px;
    margin: 30px auto;
    padding-bottom: 30px;
  }
}

How should this be manually tested?

You can test it on the page where the following entities are defined.

  • jquery-3.6.1.min.js
  • bootstrap-5.2.0
  • summernote-0.8.18 (lite)

Checklist

  • [x] Added relevant tests or not required
  • [x] Didn't break anything

aliyilmaz avatar Sep 13 '22 09:09 aliyilmaz

Have you tested if this affects the other versions of Summernote. If it does then maybe this change should only be made to the BS5 version.

DennisSuitters avatar Sep 13 '22 10:09 DennisSuitters

Have you tested if this affects the other versions of Summernote. If it does then maybe this change should only be made to the BS5 version.

I haven't tested the others.

ghost avatar Sep 13 '22 12:09 ghost

Hi @aliyilmaz I was wondering if you've had time to test this in the other versions of Summernote?

DennisSuitters avatar Nov 11 '22 12:11 DennisSuitters

Hi @aliyilmaz I was wondering if you've had time to test this in the other versions of Summernote?

Hello, unfortunately I did not have the opportunity to try it.

ghost avatar Nov 14 '22 21:11 ghost