sumatrapdf icon indicating copy to clipboard operation
sumatrapdf copied to clipboard

Custom ToolbarText buttons behave differently from the default ones

Open eugenesvk opened this issue 4 months ago • 2 comments

SumatraPDF version

  • 3.6.17065 64 bit pre-release

Describe the bug Unlike the default button, custom find command button is NOT disabled when no action is possible (the find field is empty), you can still press it, it just does nothing.

	[
		Cmd = CmdFindPrev
		Key = Ctrl+Alt+.
		ToolbarText = my_btn
	]

To Reproduce Steps to reproduce the behavior:

  1. Add custom button to you config
  2. Make sure the find field is empty
  3. Observe that the default "previous" button is inactive/can't be pressed
  4. Observe that the new "my_btn" button is active

Expected behavior The button should be inactive if it can't be used

File that reproduces the problem n/a

Screenshots n/a

Additional context Also, the default button looses tooltip for some reason

eugenesvk avatar Sep 12 '25 17:09 eugenesvk

the stock find next or previous is always visible even when non fuctioning with or without letters so it matters not is a page has or has not text find is always active. Only browsers may have a floating find box and I think that was perhaps altered ? in a past simplification so only appears when there is no toolbox and uses system based F3.

Image Image

GitHubRulesOK avatar Sep 12 '25 18:09 GitHubRulesOK

The issue here isn't visibility, but inactive status: you can't press the default prev/next buttons if the field is empty. That's a general UI button feature.

eugenesvk avatar Sep 13 '25 03:09 eugenesvk