sumatrapdf icon indicating copy to clipboard operation
sumatrapdf copied to clipboard

Dark Mode Issue

Open TemkinTegegn opened this issue 1 year ago • 10 comments

282680884-c6325d88-387c-4f9b-b3d6-ddcec58563f0 As you can see in this screenshot. I selected dark mode but the reading background is still white and when I switch it to light mode, the reading background background will be dark. So my question is how can I make the reading background dark in dark mode and why it can make it dark automatically when I switch it to dark mode by itself?

TemkinTegegn avatar Nov 14 '23 06:11 TemkinTegegn

There has been some recent changes in experimental pre-release to allow custom colour choices so depends on the revision However the canvas inversion setting should be just as easy to flip, so as before, just press i key.

Ok there does seem to be a problem with light scheme

@kjk in light scheme the inversion is not functioning ? unless colours are reversed !

FixedPageUI [
	TextColor = #ffffff
	BackgroundColor = #000000

GitHubRulesOK avatar Nov 14 '23 12:11 GitHubRulesOK

You can press i which inverts colors and will make document / text match the color.

We don't do it by default because that's not what most people want.

kjk avatar Nov 14 '23 20:11 kjk

There has been some recent changes in experimental pre-release to allow custom colour choices so depends on the revision However the canvas inversion setting should be just as easy to flip, so as before, just press i key.

Ok there does seem to be a problem with light scheme

@kjk in light scheme the inversion is not functioning ? unless colours are reversed !

FixedPageUI [
	TextColor = #ffffff
	BackgroundColor = #000000

image I set invercolors to true and it get what I wanted but you cannot change the color no matter what. It's like take-or-leave-it kind of option.

TemkinTegegn avatar Nov 20 '23 05:11 TemkinTegegn

image As you can see, the color change I made in advanced options doesn't have any effect at all! BTW, check the icons also image

TemkinTegegn avatar Nov 20 '23 05:11 TemkinTegegn

Is there any chance of setting colors per theme? I'm using blueprint-style for reading schemas (that helps so much, especially in terms of eye fatigue), but for book reading the green on black is much better. And in other hand watching color printed things like catalogues needs colors to be unchanged. Anytime I need to swap settings file because simple inversion there is not enough.

ArmanHayots avatar Dec 27 '23 09:12 ArmanHayots

@ArmanHayots there always has been colour setting and that's why themes are such a problem there is a fixed range of colours between 2 endpoints green and any other image image image

GitHubRulesOK avatar Dec 27 '23 12:12 GitHubRulesOK

@GitHubRulesOK in my case ability to set text and background colors per theme is more than enough.

ArmanHayots avatar Dec 29 '23 20:12 ArmanHayots

As long as I can remember you could have 2 profiles and send a document and page number from one to the other, this does require some customisation by users setting a command and their choice of a name/hotkey, since every user would want their own one of thousands of dark side modes.

Now SumatraPDF pre-release has a few problems with the way it handles commands ! so the current best way is write a cmd file and call it via externalviewers

ExternalViewers [
	[
		CommandLine = C:\Users\lez\AppData\Local\SumatraPDF\plus\SumatraPDF2.cmd %p %1
		Name = Suma&traPDF2
	]
]

shortcut is thus ALT +F + T image

in that folder alongside the cmd file is another copy of portable sumatraPDF.exe which uses its own settings with different preferences so can be no menu no tabs or simply a different colour setting. image

SumatraPDF2.cmd

"C:\Users\lez\AppData\Local\SumatraPDF\plus\SumatraPDF.exe" -page %1 %2

GitHubRulesOK avatar Dec 29 '23 22:12 GitHubRulesOK

is this to be fixed?

wdblue34 avatar Feb 20 '24 15:02 wdblue34

@wdblue34

In theory this issue was handled long ago. there is very little ability in any PDF reader to alter colours unless like Adobe Reader you edit the PDF objects entries. Edge Powered by Acrobat is unlikely to do better unless the full editing DC reader is imbedded.

JavaScript PDF.js readers can do little more than also set foreground and background end points to their colour rendering.

You can press i which inverts colors and will make document / text match the color.

We don't do it by default because that's not what most people want.

GitHubRulesOK avatar Feb 20 '24 21:02 GitHubRulesOK

JavaScript PDF.js readers can do little more than also set foreground and background end points to their colour rendering.

On this note, it may be worth looking into Emacs pdf-tools, which uses the OKLab colour space to do true colour remapping (e.g. https://github.com/vedang/pdf-tools/pull/197). In my experience, the results are very good.

bradrn avatar Mar 12 '24 02:03 bradrn

Things get even worse. Windows 11, dark mode on.

w

ArmanHayots avatar Apr 05 '24 04:04 ArmanHayots

I believe this issue is resolved by pressing i to invert colors to match the theme.

If not, please open a new issue is describe what is happening and what you expect to happen.

People also raised other issues but the rule is: one clear problem per issue. Don't add more stuff to existing issues, even if adjacent or similar. Unless it is the exactly same problem, open a new issue.

kjk avatar Apr 23 '24 22:04 kjk