sumatrapdf icon indicating copy to clipboard operation
sumatrapdf copied to clipboard

Poor contrast in dark mode

Open LinuxOnTheDesktop opened this issue 2 years ago • 10 comments

Here is a pdf displayed when using the 'dark' mode and the inverted colours setting:

image

Here is the same pdf, displayed via the 'darker' mode and, again, inverted colours:

image

Neither of those cases produces enough contrast. Compare the same pdf in light mode (and without colour inversion):

image

Compare also the same words but displayed via a different application and with a custom background colour - here the contrast is good:

image

Sumatra 3.5.2 (on Windows)

LinuxOnTheDesktop avatar Oct 25 '23 11:10 LinuxOnTheDesktop

there are several issues involved when inverting pixels the biggest problem as shown by the poor toolbar rendering is antialiasing does not expect to be inverted. Anti anti aliasing would simply be jaggy aliased edges. So when edges of thin vector characters almost touch there will be no white pixels, the secondary issue is even if characters are bigger the white pixels have been set to off white by a theming percentage so a dull grey.

GitHubRulesOK avatar Oct 25 '23 14:10 GitHubRulesOK

how to turn on dark mode?

amuza2 avatar Oct 31 '23 11:10 amuza2

how to turn on dark mode?

image

tactilis avatar Oct 31 '23 11:10 tactilis

how to turn on dark mode?

the book content is still white only the software interface is black!

amuza2 avatar Oct 31 '23 20:10 amuza2

@amuza2 which version ? image image use I key to toggle in 3.5.2

image

GitHubRulesOK avatar Oct 31 '23 20:10 GitHubRulesOK

@amuza2

which version ? use I key to toggle in 3.5.2

@GitHubRulesOK ok it's working now, I used the toggle I key. I didn't know about the toggle key until now, thanks for helping me

amuza2 avatar Oct 31 '23 21:10 amuza2

@kjk Most users expect Dark mode to be pure inversion of white on black as per previous suggestions all over the web simply say set light mode colour black is white then turn that black !! clearly a problem with the toolbar area. so when inverting toolbar area all text would need 100% inversion too. The issue of thinned down lettering is clearly down to antialiasing does not work well in toolbar and also likewise in thin text.

image

GitHubRulesOK avatar Nov 03 '23 15:11 GitHubRulesOK

@GitHubRulesOK This behavior looks like the problem is caused by the icons. As if this antialiasing consists in light gray pixels with full opacity at the edges of all lines. And if you replace these light gray pixels with semi-transparent black ones, everything will fall into place.

HLEBNY avatar Dec 20 '23 04:12 HLEBNY

@HLEBNY the problem is those are not pixels they are lines with antialiased edges when converted into pixels so they dont have any colours except black and its feathering and thus black on black is the common complaint about lettering lines and images. There is no easy way to set inversion of colors without some damage and that's the good reason its does not sit well with a multi format application every single object would need a different rendering state. the easiest solutions would be to revert to pixels for toolbar and have 2 sets, or have no icons. image

GitHubRulesOK avatar Dec 20 '23 10:12 GitHubRulesOK

@GitHubRulesOK oh, I see… BTW, returning to the title of issue, as I am a person who never uses toolbar, my humble main request is a mode with dark window borders and scrollbars with ability of classic 100% color inversion :)

HLEBNY avatar Dec 28 '23 21:12 HLEBNY