Issues with Favourites

[kerryland]

There are some bugs with favourites.

Step 1. Open a document without any favourites (eg: https://github.com/sumatrapdfreader/sumatrapdf/files/12641281/bug3551-Emma.-.Jane.Austen.pdf) Step 2. ctrl-b to add a favourite. Name it "p1"

Bug 1: 'Favourites' section does not appear below 'Bookmarks'

Step 3. Select "Show Favorites" from the "Favorites" menu (incidentally, I expected to find it on the "View" menu, beside all the other "Show...:" menu items

Bug 2: The "p1" favourite is rendered strangely

Step 4: Go to page 2 Step 5: Double-click on the "p1" favourite

Bug 3: Nothing happens. You are not navigated to page 1.

Step 6: Still on page 2, create another favourite, "p2" Step 7: Celebrate! We now have working favourites, both p1 and p2.

Step 8: Right click on p1 and delete the favourite (notice that Bug 2 has returned) Step 9: Right click on p2 and delete the favourite

Bug 4: The "Favorites" pane has totally disappeared. That shouldn't happen unless I uncheck "Show Favorites"