sumatrapdf icon indicating copy to clipboard operation
sumatrapdf copied to clipboard

Remove Open Folder

Open kjk opened this issue 3 years ago • 6 comments

Doesn't work right

kjk avatar May 29 '22 23:05 kjk

When opening a folder, the 'Bookmarks' shows wrong filenames.

Steps to reproduce:

  1. put some image files inside a folder and give them different filename e.g. 1.jpg, 2.jpg, 3.jpg
  2. open the folder with SumatraPDF
  3. The 'Bookmarks' shows 3 files, but all have '1' as the filename.

2022-05-30_125000

onmyouji avatar May 30 '22 05:05 onmyouji

Hmm wile testing Avif corpus I have 176 x Fox but the page name says star

image

GitHubRulesOK avatar May 31 '22 17:05 GitHubRulesOK

This is not so easy to fix, not very useful and I don't even remember why I've added it.

It's broken, people don't complain so it's probably not used often.

In the short term, I'll remove it.

In the longer term, maybe re-implement it as a separate tab that shows a list of files in the folder. Or maybe on-demand window, kind of like command palette, that can be invoked to select next file from a folder to open.

kjk avatar Jun 06 '22 21:06 kjk

It is a good feature, it loads the files in the folder well, it only needs to be able to open them, now it only opens the first one. It is useful for folders of periods, series / collections, brands or specific documents.

dominiosc avatar Jun 11 '22 20:06 dominiosc

@kjk the broken aspect is odd since a zip folder (like cbz) shows filenames here I can see one is 175 the other is 176 ! so for some reason the zip shows one as missing but without the folder names it was tough to tell it is fox.profile0.8bpc.yuv420b.avif which is a valid picture !! https://github.com/link-u/avif-sample-images/archive/refs/heads/master.zip fox.profile0.8bpc.yuv420b image

Also 2 other svgs and text files can be viewed but not expected by SumatraPDF in zip or folder yet are valid as views

GitHubRulesOK avatar Jun 11 '22 22:06 GitHubRulesOK

When opening a folder, the 'Bookmarks' shows wrong filenames.

Steps to reproduce:

1. put some image files inside a folder and give them different filename e.g. 1.jpg, 2.jpg, 3.jpg

2. open the folder with SumatraPDF

3. The 'Bookmarks' shows 3 files, but all have '1' as the filename.

2022-05-30_125000

First load, show path and the names correctly. imagen

Second load, not show path and all names the same. imagen

When open folder (alt+o) the first time the names show correctly, but if close sumatra when reopen all the names are the same, the first.

Bookmarks in 15189 they work a little better, if the folder have only image work good, except if there are .webp images. (the .webp images work if rename the extension)

But if the folder have only PDFs, bookmarks file selection to view one, not work. You can navigate with the buttons forward and back, but not select file from bookmark. Apparently, it loads the pages of all documents as a single document and not only the one that is selected, with the images work correctly because one image is how one page and loop through the array of elements just fine.

Please keep this functionality.

dominiosc avatar Jun 24 '22 02:06 dominiosc